HDDS-2019. Handle Set DtService of token in S3Gateway for OM HA.#1489
Merged
bharatviswa504 merged 6 commits intoapache:trunkfrom Oct 2, 2019
Merged
HDDS-2019. Handle Set DtService of token in S3Gateway for OM HA.#1489bharatviswa504 merged 6 commits intoapache:trunkfrom
bharatviswa504 merged 6 commits intoapache:trunkfrom
Conversation
bharatviswa504
force-pushed
the
HDDS-2019
branch
from
5116ef9 to
9ef2a77
Compare
xiaoyuyao
reviewed
Sep 23, 2019
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneServiceProvider.java
Outdated
Show resolved
Hide resolved
xiaoyuyao
reviewed
Sep 23, 2019
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneServiceProvider.java
Outdated
Show resolved
Hide resolved
xiaoyuyao
reviewed
Sep 23, 2019
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/util/OzoneS3Util.java
Outdated
Show resolved
Hide resolved
xiaoyuyao
reviewed
Sep 23, 2019
Contributor
xiaoyuyao
left a comment
xiaoyuyao
left a comment
There was a problem hiding this comment.
LGTM overall, a few comments inline
bharatviswa504
force-pushed
the
HDDS-2019
branch
from
9ef2a77 to
1507209
Compare
Contributor
Author
|
Thank You @xiaoyuyao for the review. |
Contributor
Author
|
Ping @xiaoyuyao for the review. |
xiaoyuyao
reviewed
Sep 30, 2019
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/util/TestOzoneS3Util.java
Outdated
Show resolved
Hide resolved
xiaoyuyao
reviewed
Sep 30, 2019
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/util/TestOzoneS3Util.java
Outdated
Show resolved
Hide resolved
xiaoyuyao
reviewed
Sep 30, 2019
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneServiceProvider.java
Show resolved
Hide resolved
xiaoyuyao
reviewed
Sep 30, 2019
Contributor
xiaoyuyao
left a comment
xiaoyuyao
left a comment
There was a problem hiding this comment.
Few minor comments added.
Contributor
Author
|
Thank You @xiaoyuyao for the review. |
Contributor
|
LGTM, +1. |
Contributor
Author
|
Thank You @xiaoyuyao for the review. |
amahussein
pushed a commit
to amahussein/hadoop
that referenced
this pull request
Oct 29, 2019
RogPodge
pushed a commit
to RogPodge/hadoop
that referenced
this pull request
Mar 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need some work on server-side for adding secure-om-s3-ha docker-compose cluster, as some fields like keytab are still not supporting parameter with serviceid and node id.